Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements to plutus debug #4503

Merged
merged 4 commits into from
Jul 24, 2024
Merged

Improvements to plutus debug #4503

merged 4 commits into from
Jul 24, 2024

Conversation

lehins
Copy link
Collaborator

@lehins lehins commented Jul 23, 2024 •
edited
Loading

Description

  1. Resolves Move plutus-debug into cardano-ledger-api #3920
  2. Improves plutus debugging by adding expected execution units to the produced error

Unrelated conway fixups:

  1. Adds a bit of documentation to Conway CDDL that was requested on Slack
  2. Fix cardano-ledger-conway version in the cabal file

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages. New section is never added with the code changes. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

@lehins lehins changed the title Lehins/improvements to plutus debug Improvements to plutus debug Jul 23, 2024
@lehins lehins force-pushed the lehins/improvements-to-plutus-debug branch 2 times, most recently from 44289d3 to d1d2d8d Compare July 23, 2024 21:08
@lehins lehins requested a review from Lucsanszky July 23, 2024 21:08
Lucsanszky
Lucsanszky approved these changes Jul 24, 2024
View reviewed changes
Copy link
Contributor

@Lucsanszky Lucsanszky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

eras/conway/impl/cardano-ledger-conway.cabal Show resolved Hide resolved
@Lucsanszky Lucsanszky force-pushed the lehins/improvements-to-plutus-debug branch from d1d2d8d to 5500f8f Compare July 24, 2024 03:58
@lehins
Improve PlutusDebug error reporting
8b5fa4a 
It is often that we need to learn what was the desired execution units
when the budget is exhausted. This commit adds this ability to
plutus-debug
@lehins
Move plutus-debug executable into cardano-ledger-core
d54b189
@lehins
Add documentation for CDDL definitions of set, nonempty_set and…
0a23af4 
… `nonempty_oset`
@lehins
Fix cardano-ledger-conway version
75a5128
@lehins lehins force-pushed the lehins/improvements-to-plutus-debug branch from 5500f8f to 75a5128 Compare July 24, 2024 16:25
@lehins lehins enabled auto-merge July 24, 2024 16:25
@lehins lehins merged commit aa1dbc4 into master Jul 24, 2024
124 of 126 checks passed
@lehins lehins deleted the lehins/improvements-to-plutus-debug branch July 24, 2024 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lucsanszky Lucsanszky Lucsanszky approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move plutus-debug into cardano-ledger-api
2 participants
@lehins @Lucsanszky